From 19919aa0e0f1c11a6b1a683ce77bf3e872d33d86 Mon Sep 17 00:00:00 2001
From: Kelp <kelp@phate.org>
Date: Mon, 25 Mar 2013 15:11:48 +0800
Subject: [PATCH] fixed issues #1. thanks @jasperblues

fixed bug in Base64 encode. (encode empty data)
clean up hex encode/decode.
---
 CocoaSecurity/CocoaSecurity.m           | 12 ++++++++----
 CocoaSecurityTests/CocoaSecurityTests.m |  4 ++++
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/CocoaSecurity/CocoaSecurity.m b/CocoaSecurity/CocoaSecurity.m
index 2cd6ff4..6d9446b 100644
--- a/CocoaSecurity/CocoaSecurity.m
+++ b/CocoaSecurity/CocoaSecurity.m
@@ -581,7 +581,7 @@
 {
     static const char lookup[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
     
-    NSUInteger inputLength = [data length];
+    long long inputLength = [data length];
     const unsigned char *inputBytes = [data bytes];
     
     long long maxOutputLength = (inputLength / 3 + 1) * 4;
@@ -604,7 +604,7 @@
         outputBytes[outputLength++] = lookup[(inputBytes[index] & 0xFC) >> 2];
         outputBytes[outputLength++] = lookup[((inputBytes[index] & 0x03) << 4) | ((inputBytes[index + 1] & 0xF0) >> 4)];
         outputBytes[outputLength++] = lookup[(inputBytes[index + 1] & 0x0F) << 2];
-        outputBytes[outputLength++] =   '=';
+        outputBytes[outputLength++] = '=';
     }
     else if (index == inputLength - 1)
     {
@@ -629,8 +629,10 @@
 // convert NSData to hex string
 - (NSString *)hex:(NSData *)data useLower:(BOOL)isOutputLower
 {
-    static const char HexEncodeCharsLower[] = { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f' };
-    static const char HexEncodeChars[] = { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F' };
+    if (data.length == 0) { return nil; }
+    
+    static const char HexEncodeCharsLower[] = "0123456789abcdef";
+    static const char HexEncodeChars[] = "0123456789ABCDEF";
     char *resultData;
     // malloc result data
     resultData = malloc([data length] * 2 +1);
@@ -717,6 +719,8 @@
 }
 - (NSData *)hex:(NSString *)data
 {
+    if (data.length == 0) { return nil; }
+    
     static const unsigned char HexDecodeChars[] = 
     {
         0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
diff --git a/CocoaSecurityTests/CocoaSecurityTests.m b/CocoaSecurityTests/CocoaSecurityTests.m
index 4563ff7..d99f5a3 100644
--- a/CocoaSecurityTests/CocoaSecurityTests.m
+++ b/CocoaSecurityTests/CocoaSecurityTests.m
@@ -32,9 +32,13 @@
     // HEX
     STAssertEqualObjects([encoder hex:[decoder hex:@"CC0A69779E15780ADAE46C45EB451A23"] useLower:false],
                          @"CC0A69779E15780ADAE46C45EB451A23", nil);
+    STAssertNil([encoder hex:[NSData new] useLower:YES], nil);
+    STAssertNil([decoder hex:@""], nil);
     
     // Base64
     STAssertEqualObjects([encoder base64:[decoder base64:@"zT1PS64MnXIUDCUiy13RRg=="]], @"zT1PS64MnXIUDCUiy13RRg==", nil);
+    STAssertNil([encoder base64:[NSData new]], nil);
+    STAssertNil([decoder base64:@""], nil);
 }
 
 - (void)testAES